Make IcebergTableProvider::try_new public#2000
Draft
smaheshwar-pltr wants to merge 1 commit intoapache:mainfrom
Draft
Make IcebergTableProvider::try_new public#2000smaheshwar-pltr wants to merge 1 commit intoapache:mainfrom
IcebergTableProvider::try_new public#2000smaheshwar-pltr wants to merge 1 commit intoapache:mainfrom
Conversation
pratik0316
reviewed
Jan 6, 2026
| /// Loads the table once to get the initial schema, then stores the catalog | ||
| /// reference for future metadata refreshes on each operation. | ||
| pub(crate) async fn try_new( | ||
| pub async fn try_new( |
Collaborator
There was a problem hiding this comment.
+1, I don't think this should be made public. It's more recommended to use IcebergCatalogProvider indirectly register table providers. But would love to hear the use case if any
Contributor
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?